Developing a real estate advertisement module from scratch by pasaw-odoo · Pull Request #1188 · odoo/tutorials

pasaw-odoo · 2026-03-10T11:36:15Z

Setup and install real estate module
Declaring model class and creating estate property table in database via odoo orm
implementing access rights

robodoo · 2026-03-10T11:36:19Z

Setup and install real estate module Declaring model class and creating estate property table in database via odoo orm implementing access rights

-added default view (list and form) in chapter 5 with some field attributes -added custom view (list and form) in chapter 6

-chapter 6 search view added

mash-odoo

Hello!
Great start to the task! 🐣
Here are some comments and suggestions, please have a look.
Also change the PR title and description!

mash-odoo · 2026-03-16T09:26:16Z

estate/demo/demo.xml

@@ -0,0 +1,198 @@
+<odoo>
+  <data>


What's the purpose of this data tag?
Will there be any impact if we remove it?

The tag was used in older Odoo versions and is now completely optional. But if we are using noupdate="1", the logic is — when a user renames a field and saves it in the DB, but the .xml file on disk doesn't change, then on upgrade the old data comes back from the XML. But with noupdate="1" it doesn't update and keeps what the user had renamed. And if we are writing inside the tag and want to apply noupdate="1" to all records we can put it directly on , but if we want to apply it to only a few records then we can add a separate block for those specific ones.

mash-odoo · 2026-03-16T09:26:40Z

estate/demo/demo.xml

+    </record>
+
+  </data>
+</odoo>


Always leave an extra line at the end of the file.

mash-odoo · 2026-03-16T09:45:22Z

estate/models/estate_property.py

+from dateutil.relativedelta import relativedelta
+from odoo import fields, models
+
+
+class EstateProperty(models.Model):


Follow these guidelines to import in a correct order and proper format.

mash-odoo · 2026-03-16T09:48:17Z

estate/models/estate_property.py

+    name = fields.Char(string='Property Name', required=True, help='Enter the name of the property')
+    description = fields.Text(string='Property Description', help='Enter a description of the property')


Suggested change

name = fields.Char(string='Property Name', required=True, help='Enter the name of the property')

description = fields.Text(string='Property Description', help='Enter a description of the property')

name = fields.Char(string="Property Name", required=True, help='Enter the name of the property')

description = fields.Text(string="Property Description", help='Enter a description of the property')

Functional strings (the strings which are shown to user) should be in double quotes.

mash-odoo · 2026-03-16T09:49:28Z

estate/models/estate_property.py

+
+    name = fields.Char(string='Property Name', required=True, help='Enter the name of the property')
+    description = fields.Text(string='Property Description', help='Enter a description of the property')
+    postcode = fields.Char(string='Postcode', help='Enter the postcode of the property')


Suggested change

postcode = fields.Char(string='Postcode', help='Enter the postcode of the property')

postcode = fields.Char(help='Enter the postcode of the property')

Even if you don't mention string here, it will directly take the field name.

mash-odoo · 2026-03-16T09:50:40Z

estate/models/estate_property.py

+    name = fields.Char(string='Property Name', required=True, help='Enter the name of the property')
+    description = fields.Text(string='Property Description', help='Enter a description of the property')
+    postcode = fields.Char(string='Postcode', help='Enter the postcode of the property')
+    date_availability = fields.Date(string='Availability Date', help='Enter the date when the property becomes available', copy=False, default=lambda self: fields.Date.today() + relativedelta(months=3))


Nit: try to make it <100 for a better readability.

Suggested change

date_availability = fields.Date(string='Availability Date', help='Enter the date when the property becomes available', copy=False, default=lambda self: fields.Date.today() + relativedelta(months=3))

date_availability = fields.Date(

string='Availability Date',

help='Enter the date when the property becomes available',

copy=False,

default=lambda self: fields.Date.today() + relativedelta(months=3)

)

mash-odoo · 2026-03-16T09:51:42Z

estate/models/estate_property.py

+        selection=[
+            ('north', 'North'),
+            ('south', 'South'),
+            ('east', 'East'),
+            ('west', 'West'),
+        ],


Suggested change

selection=[

('north', 'North'),

('south', 'South'),

('east', 'East'),

('west', 'West'),

],

selection=[

('north', "North"),

('south', "South"),

('east', "East"),

('west', "West"),

],

keep the key in single quotes and value in double quotes

mash-odoo · 2026-03-16T09:52:04Z

estate/views/estate_menus.xml

+        </menuitem>
+
+    </menuitem>


Suggested change

</menuitem>

</menuitem>

</menuitem>

</menuitem>

mash-odoo · 2026-03-16T09:52:39Z

estate/views/estate_property_views.xml

+                <filter
+                    name="available"
+                    string="Available"
+                    domain="['|', ('state', '=', 'new'), ('state', '=', 'offer_received')]"


Can you optimize this domain?

mash-odoo · 2026-03-16T09:53:22Z

estate/__manifest__.py

+        'demo/demo.xml',
+    ],
+    'application': True,
+    'installable': True,


What's the meaning of installable true?

installable true means it becomes visible in all filter and we can install that specific module

we dont need to write this as it is already true in default manifest which is in module.py

- Added new models: Property Type, Property Tag, and Property Offer. - Implemented relations: Many2one (Type, Buyer, Seller), Many2many (Tags), and One2many (Offers). - Added views (List, Form) for the new models. - Added 'image' field to Property form and module web icon.

- Added demo data for property types , property tags and enhanced search view

- add total_area computed field (living_area + garden_area) - add best_price computed field (max of offer prices) - add onchange on garden field (auto-fill area and orientation) - add date_deadline computed field on estate.property.offer - add inverse on date_deadline to sync validity days

mash-odoo

Hello!
Thank you for your work..
Here are a few questions and suggestions.

mash-odoo · 2026-03-25T09:20:01Z

estate/demo/demo_tag.xml

+        <field name="name">Gated Community</field>
+    </record>
+
+</odoo>


Always add an extra line at the end of the file!!

mash-odoo · 2026-03-25T09:24:56Z

estate/models/estate_property.py

+        string="Garden Orientation",
+        help='Select the orientation of the garden'
+    )
+    active = fields.Boolean(string="Active", default=True, help='Set to False to archive the property')


Suggested change

active = fields.Boolean(string="Active", default=True, help='Set to False to archive the property')

active = fields.Boolean(default=True, help='Set to False to archive the property')

No need to add the string. By default it will take the string from the field name

mash-odoo · 2026-03-25T09:25:47Z

estate/models/estate_property.py

+    )
+    property_type_id = fields.Many2one('estate.property.type', string="Property Type")
+    buyer_id = fields.Many2one('res.partner', string="Buyer", copy=False)
+    seller_id = fields.Many2one('res.users', string="Salesperson", default=lambda self:self.env.user)


What is a lambda function? And why do we need to use this function here?

mash-odoo · 2026-03-25T09:31:17Z

estate/models/estate_property_offer.py

+
+class EstatePropertyOffer(models.Model):
+    _name = 'estate.property.offer'
+    _description = 'Estate Property Offer'


Suggested change

_description = 'Estate Property Offer'

_description = "Estate Property Offer"

This will be displayed in UI so you can keep it in double quotes

mash-odoo · 2026-03-25T09:32:13Z

estate/models/estate_property_offer.py

+            ('accepted', "Accepted"),
+            ('refused', "Refused"),
+        ],
+        string="Status",


Suggested change

string="Status",

You don't need to explicitly mention the string unless you want a different display name than the field name.

mash-odoo · 2026-03-25T09:33:58Z

estate/views/estate_property_views.xml

+                <field name="name" optional="show"/>
+                <field name="property_type_id" optional="show"/>
+                <field name="postcode" optional="show"/>
+                <field name="tag_ids" widget="many2many_tags" optional="show"/>


What's the purpose of this widget?

mash-odoo · 2026-03-25T09:34:29Z

estate/views/estate_property_views.xml

+            <list limit="50" decoration-danger="state == 'canceled'" decoration-success="state == 'sold'">
+                <field name="name" optional="show"/>
+                <field name="property_type_id" optional="show"/>
+                <field name="postcode" optional="show"/>


What is the purpose of this optional attribute?

mash-odoo · 2026-03-25T09:36:45Z

estate/views/estate_property_views.xml

+            <filter 
+                string="Available" 
+                name="available"
+                domain="[('state','in',['new','offer_received'])]"/>


Suggested change

domain="[('state','in',['new','offer_received'])]"/>

domain="[('state', 'in', ['new', 'offer_received'])]"/>

Leave an extra space after adding a comma.

mash-odoo · 2026-03-25T09:38:16Z

estate/views/estate_property_views.xml

+                string="Archived"
+                name="archived"
+                domain="[('active','=',False)]"/>
+            <separator/>


Why do we use this separator?
Also do you know where is it coming from?

mash-odoo · 2026-03-25T09:38:39Z

estate/__manifest__.py

+        'views/estate_menus.xml',
+
+    ],


Suggested change

'views/estate_menus.xml',

],

'views/estate_menus.xml',

],

pasaw-odoo force-pushed the 19.0-tutorials-estate-pasaw branch 2 times, most recently from b69f8cc to 540d490 Compare March 10, 2026 12:47

[ADD] estate: finish Chapters 2-4 (module & model)

8b78ab6

Setup and install real estate module Declaring model class and creating estate property table in database via odoo orm implementing access rights

pasaw-odoo force-pushed the 19.0-tutorials-estate-pasaw branch from 540d490 to 8b78ab6 Compare March 10, 2026 12:53

[ADD] estate: chapter 5 and chapter 6 (list and forms done)

83d1383

-added default view (list and form) in chapter 5 with some field attributes -added custom view (list and form) in chapter 6

pasaw-odoo force-pushed the 19.0-tutorials-estate-pasaw branch from 5bb84ef to 83d1383 Compare March 12, 2026 16:57

[IMP] estate:chapter 6

b97eef7

-chapter 6 search view added

mash-odoo requested changes Mar 17, 2026

View reviewed changes

pasaw-odoo added 2 commits March 18, 2026 18:55

[IMP] estate: fix linting issues

cb8ff1b

pasaw-odoo force-pushed the 19.0-tutorials-estate-pasaw branch from cd3db74 to cb8ff1b Compare March 19, 2026 02:07

pasaw-odoo added 2 commits March 19, 2026 21:15

[IMP] estate: some improvements till chapter 7

722f7fb

- Added demo data for property types , property tags and enhanced search view

[REM] tutorials: remove README.md

68a2994

pasaw-odoo force-pushed the 19.0-tutorials-estate-pasaw branch from 0d9d48c to 68a2994 Compare March 19, 2026 16:12

pasaw-odoo changed the title ~~[ADD] estate: finish Chapters 2-3 (module & model)~~ Developing a real estate advertisement module from scratch Mar 19, 2026

mash-odoo requested changes Mar 25, 2026

View reviewed changes

		name = fields.Char(string='Property Name', required=True, help='Enter the name of the property')
		description = fields.Text(string='Property Description', help='Enter a description of the property')

	postcode = fields.Char(string='Postcode', help='Enter the postcode of the property')
	postcode = fields.Char(help='Enter the postcode of the property')

	active = fields.Boolean(string="Active", default=True, help='Set to False to archive the property')
	active = fields.Boolean(default=True, help='Set to False to archive the property')

	_description = 'Estate Property Offer'
	_description = "Estate Property Offer"

	domain="[('state','in',['new','offer_received'])]"/>
	domain="[('state', 'in', ['new', 'offer_received'])]"/>

Conversation

pasaw-odoo commented Mar 10, 2026

Uh oh!

robodoo commented Mar 10, 2026

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mash-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants